Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4: Document SplObjectStorage::seek() の翻訳 #219

Merged
merged 2 commits into from
Dec 21, 2024
Merged

PHP 8.4: Document SplObjectStorage::seek() の翻訳 #219

merged 2 commits into from
Dec 21, 2024

Conversation

siwa32
Copy link
Contributor

@siwa32 siwa32 commented Dec 19, 2024

refs #150

php/doc-en#4048 を取り込みました。

  • seekableiterator/seek.xml はインデントが崩れていたため合わせて修正
  • SplObjectStorage::seek は SeekableIterator::seek を参考に翻訳

KentarouTakeda
KentarouTakeda approved these changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。インデント調整含め非常に助かりました！

@KentarouTakeda KentarouTakeda merged commit 2a586fd into php:master Dec 21, 2024
1 check passed
@KentarouTakeda KentarouTakeda mentioned this pull request Dec 21, 2024
Open
@siwa32 siwa32 deleted the doc-en/4048_spl-objectstorage-seek branch December 21, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KentarouTakeda KentarouTakeda KentarouTakeda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siwa32 @KentarouTakeda