[PHP8.4] Change PHP_DEBUG and PHP_ZTS to bool の翻訳 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asumikam
force-pushed
the
Change-PHP_DEBUG-and-PHP_ZTS-to-bool
branch
from
cc5d547 to
7c78c48
Compare
asumikam
changed the title
asumikam
changed the title
asumikam
force-pushed
the
Change-PHP_DEBUG-and-PHP_ZTS-to-bool
branch
from
7c78c48 to
51ccf25
Compare
KentarouTakeda
added
the
review wanted
KentarouTakeda
approved these changes
Nov 23, 2024
| @@ -108,7 +108,8 @@ | |||
| <varlistentry xml:id="constant.php-zts"> | |||
| <term> | |||
| <constant>PHP_ZTS</constant> | |||
| (<type>int</type>) | |||
| (<type>bool</type>) | |||
| <constant>ZEND_THREAD_SAFE</constant> &Alias; | |||
There was a problem hiding this comment.
LGTM!
これナイスです！文章の構造のため、原文と順序が逆になるんですね。レビューで初めて知りました…
私が訳してたら、半端に慣れてるおかげでむしろ間違えていたかもしれない😇
There was a problem hiding this comment.
私もプレビューで見て、「なんか・・・これ変だな・・・」ってなって気づきました！ww
ありがとうございます！！！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #150
php/doc-en#3078 の翻訳作業をしました🍥