-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "Flags" title in format
parameter of sprintf
#4551
base: master
Are you sure you want to change the base?
Conversation
"Flags" as a title already appears on the page, but it shows as a centered title above the table, which is confusing to readers. Could you correct that instead of your current suggestion, please? |
I have to surround the section with |
Hi @tiffany-taylor I have those errors :
IMO we have to have both (section and table titles). It will be weird to have the title twice but less confusing than not have section title. WDYT ? |
</para> | ||
<formalpara> | ||
<title>Flags</title> | ||
<para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this wrapping para tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran your suggestions locally. The <para>
container is still needed, but <table>
can safely be changed to <informaltable>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
language-snippets.ent
Outdated
<table> | ||
<title>Flags</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<table> | |
<title>Flags</title> | |
<informaltable> |
And fix the end tag
Please see Gina's suggestions. Changing the |
It's done ! |
In
format
parameter ofsprintf
function, there is no title for theflags
parameters.BEFORE

Flags seems to be for Argnum parameter
AFTER

(I make the change with my browser inspector)
Flags are in a flags section, we understand that it's for flags