Update round() for PHP-8.4 and Minor fixes for BCMath's round
#4425
+68
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed, does this conflict with #4107 ? |
TimWolla
reviewed
Jan 29, 2025
| @@ -112,6 +112,7 @@ | |||
| </tbody> | |||
| </tgroup> | |||
| </informaltable> | |||
| However, please note that some newly added modes only exist in <link linkend="enum.roundingmode">RoundingMode</link>. | |||
There was a problem hiding this comment.
Suggested change
| However, please note that some newly added modes only exist in <link linkend="enum.roundingmode">RoundingMode</link>. | |
| However, please note that some newly added modes only exist in <enumname>RoundingMode</enumname>. |
There was a problem hiding this comment.
I can't access the enum page because there is no link, is this something plan to address?
There was a problem hiding this comment.
Yes, but currently not supported :/
reference/bc/bcmath/number/round.xml
Outdated
| <term><parameter>mode</parameter></term> | ||
| <listitem> | ||
| <simpara> | ||
| Specifies the rounding mode. | ||
| Specifies the rounding mode. For more information about modes, see <link linkend="enum.roundingmode">RoundingMode</link>. |
There was a problem hiding this comment.
Suggested change
| Specifies the rounding mode. For more information about modes, see <link linkend="enum.roundingmode">RoundingMode</link>. | |
| Specifies the rounding mode. For more information about modes, see <enumname>RoundingMode</enumname>. |
Girgias
reviewed
Jan 30, 2025
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.