Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unserialize.xml Fix typo #4328

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Update unserialize.xml Fix typo #4328

merged 1 commit into from
Dec 21, 2024

Conversation

mmalferov
Copy link
Member

No description provided.

@mmalferov
Copy link
Member Author

And shouldn't we change the type for the allowed_classes element to array|bool instead mixed in line 92?

@kamil-tekiela kamil-tekiela merged commit 6c7da86 into php:master Dec 21, 2024
2 checks passed
@kamil-tekiela
Copy link
Member

And shouldn't we change the type for the allowed_classes element to array|bool instead mixed in line 92?

I think we should. Could you please submit a new PR?

@nsfisis nsfisis mentioned this pull request Jan 13, 2025
Merged
@mmalferov mmalferov deleted the patch-304196 branch January 20, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil-tekiela kamil-tekiela kamil-tekiela approved these changes

@sy-records sy-records sy-records approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalferov @kamil-tekiela @sy-records