PHP 8.4: Document RoundingMode #4080
Merged
+113
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
approved these changes
Nov 17, 2024
Comment on lines
+25
to
+27
| Round to the nearest integer. | ||
| If the decimal part is <literal>5</literal>, | ||
| round to the integer with the larger absolute value. |
There was a problem hiding this comment.
I assume you've taken all the description from the RFC?
There was a problem hiding this comment.
The bit with the decimal part might need some adjustments either in the documentation for round() or in here, because round() supports rounding to a specified precision instead of integers.
There was a problem hiding this comment.
I have indeed taken them from the RFC, yeah the whole round() semantics is... going to be a PITA.
There was a problem hiding this comment.
I think I will merge as is, feel free to open an issue about the wording to keep track of it
Co-authored-by: Tim Düsterhus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3419 and php/phd#179