Improve _PHP: Hypertext Preprocessor_ presentation #3758
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this text is prose and not computer output, I would argue that
literal
should not be used and, if anything, we should useemphasis
for visual reasons.We are also inconsistently quoting the initialism expansion, i.e., PHP: Hypertext Preprocessor. Removing the quotes makes sense to me because we will present the term in italics.
I've also added the missing closing comma for the Preface parenthetical.
Discussion point: I don't love the What is PHP? parenthetical. It feels clunky. I would propose that we duplicate the Preface parenthetical.
I didn't make this change in this PR as it felt more opinionated. Love to hear your thoughts.
Before
After