Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve _PHP: Hypertext Preprocessor_ presentation #3758

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

timacdonald
Copy link
Contributor

@timacdonald timacdonald commented Sep 17, 2024

As this text is prose and not computer output, I would argue that literal should not be used and, if anything, we should use emphasis for visual reasons.

We are also inconsistently quoting the initialism expansion, i.e., PHP: Hypertext Preprocessor. Removing the quotes makes sense to me because we will present the term in italics.

I've also added the missing closing comma for the Preface parenthetical.

Discussion point: I don't love the What is PHP? parenthetical. It feels clunky. I would propose that we duplicate the Preface parenthetical.

PHP (recursive acronym for PHP: Hypertext Preprocessor), which stands for PHP: Hypertext Preprocessor, is a widely-used open source general-purpose scripting language that is especially suited for web development and can be embedded into HTML.

I didn't make this change in this PR as it felt more opinionated. Love to hear your thoughts.

Before

Screenshot 2024-09-17 at 10 32 52 Screenshot 2024-09-17 at 10 33 11

After

Screenshot 2024-09-17 at 10 36 00 Screenshot 2024-09-17 at 10 35 22

@Girgias Girgias merged commit 9a10d86 into php:master Sep 22, 2024
2 checks passed
@timacdonald timacdonald deleted the literals branch September 22, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants