Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document SensitiveParameter attributes - part 2 #3403

Merged
merged 1 commit into from
May 21, 2024

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate
Copy link
Member Author

cc @haszi

@haszi
Copy link
Contributor

haszi commented May 21, 2024

Looking at the attributes in the stub files, I've noticed that some functions/methods are missing both from doc-en and a consequence of that, from these PRs. The functions/methods are the following:
sodium_crypto_aead_aegis128l_decrypt()
sodium_crypto_aead_aegis128l_encrypt()
sodium_crypto_aead_aegis256_decrypt()
sodium_crypto_aead_aegis256_encrypt()
PDO::connect()
pg_change_password()

The following two functions are listed in doc-en but were not part of the two SensitiveParameter PRs:
odbc_connect()
odbc_pconnect()

Can gen_stub generate a list of function/methods that are not listed in the documentation? A list like the one you made for constants would be handy, I think.

@kocsismate
Copy link
Member Author

kocsismate commented May 21, 2024

The following two functions are listed in doc-en but were not part of the two SensitiveParameter PRs:
odbc_connect()
odbc_pconnect()

Yes, I explicitly left these out because I recently migrated these resources to objects, so a few months later we have to change the documentation anyway, and I didn't want to bother with manual changes for now.

Can gen_stub generate a list of function/methods that are not listed in the documentation? A list like the one you made for constants would be handy, I think.

Yes, it can, just like I did for constants. I created #2163
and #2162 ~1.5 years ago, and I last updated them a few months ago. You can also run ./build/gen_stub.php --verify-manual ./ ../doc-en/ manually to have a completely up-to-date output. I share one here:
https://gist.github.com/kocsismate/49f229910df3b1033d4ae8afdda52692

@haszi
Copy link
Contributor

haszi commented May 21, 2024

./build/gen_stub.php --verify-manual ./ ../doc-en/

Thanks! That's exactly what I was looking for. :-)

@Girgias Girgias merged commit d76a7fe into php:master May 21, 2024
2 checks passed
@kocsismate kocsismate deleted the sensitive-attribute2 branch May 21, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants