Skip to content

Commit

Permalink
address second round of PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ericnorris committed Jan 13, 2025
1 parent 4a1018b commit fac4701
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion reference/curl/curlsharepersistenthandle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<varlistentry xml:id="curlsharepersistenthandle.props.options">
<term><varname>options</varname></term>
<listitem>
<para>The <constant>CURL_LOCK_DATA_<replaceable>*</replaceable></constant> constants shared between requests using this handle.</para>
<para>The <constant>CURL_LOCK_DATA_<replaceable>*</replaceable></constant> caches shared between requests using this handle.</para>
</listitem>
</varlistentry>
</variablelist>
Expand Down
12 changes: 6 additions & 6 deletions reference/curl/functions/curl-share-init-persistent.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
with the given share options. Unlike <function>curl_share_init</function>,
handles created by this function will not be destroyed at the end of the
PHP request. If a persistent share handle with the same set of
<parameter>$share_options</parameter> is found, it will be reused.
<parameter>share_options</parameter> is found, it will be reused.
</para>
</refsect1>

Expand Down Expand Up @@ -54,27 +54,27 @@
<itemizedlist>
<listitem>
<simpara>
If <parameter>$share_options</parameter> is empty, this function throws
If <parameter>share_options</parameter> is empty, this function throws
a <exceptionname>ValueError</exceptionname>.
</simpara>
</listitem>
<listitem>
<simpara>
If <parameter>$share_options</parameter> contains a value not matching
If <parameter>share_options</parameter> contains a value not matching
a <constant>CURL_LOCK_DATA_<replaceable>*</replaceable></constant>,
this function throws a <classname>ValueError</classname>.
</simpara>
</listitem>
<listitem>
<simpara>
If <parameter>$share_options</parameter> contains
If <parameter>share_options</parameter> contains
<constant>CURL_LOCK_DATA_COOKIE</constant>, this function throws a
<exceptionname>ValueError</exceptionname>.
</simpara>
</listitem>
<listitem>
<simpara>
If <parameter>$share_options</parameter> contains a non-integer value,
If <parameter>share_options</parameter> contains a non-integer value,
this function throws a <exceptionname>TypeError</exceptionname>.
</simpara>
</listitem>
Expand Down Expand Up @@ -108,7 +108,7 @@ curl_exec($ch1);
$ch2 = curl_init("http://example.com/");
curl_setopt($ch2, CURLOPT_SHARE, $sh);
// Execute the second cURL handle. This will reuse the connection from $ch2.
// Execute the second cURL handle. This will reuse the connection from $ch1.
curl_exec($ch2);
// Close the cURL handles
Expand Down

0 comments on commit fac4701

Please sign in to comment.