Skip to content

Commit

Permalink
Run with docker process factory
Browse files Browse the repository at this point in the history
  • Loading branch information
AydinHassan committed May 17, 2024
1 parent f435075 commit 2da5ce2
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 13 deletions.
2 changes: 0 additions & 2 deletions .docker/runtime/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
version: '3.8'

services:
runtime:
image: php8appreciate-runtime
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
],
"require": {
"php": "^8.0",
"php-school/php-workshop": "dev-master"
"php-school/php-workshop": "dev-docker-fixes"
},
"require-dev": {
"phpunit/phpunit": "^9",
Expand Down
15 changes: 7 additions & 8 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions phpunit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,7 @@
<directory>./test</directory>
<exclude>./test/solutions</exclude>
</testsuite>
<php>
<env name="process_factory" value="docker" force="true" />
</php>
</phpunit>
1 change: 0 additions & 1 deletion src/Exercise/ThrowAnExpression.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
use PhpParser\Node\Stmt\If_;
use PhpParser\NodeFinder;
use PhpParser\Parser;
use PhpSchool\PhpWorkshop\Environment\CgiTestEnvironment;
use PhpSchool\PhpWorkshop\Exercise\AbstractExercise;
use PhpSchool\PhpWorkshop\Exercise\CgiExercise;
use PhpSchool\PhpWorkshop\Exercise\ExerciseInterface;
Expand Down
2 changes: 1 addition & 1 deletion test/Exercise/ThrowAnExpressionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public function testThrowingWrongException(): void
self::assertInstanceOf(Success::class, $output->getResults()[1]);

self::assertMatchesRegularExpression(
'/Fatal error: Uncaught Exception: Access denied!/',
'/Fatal error: Uncaught Exception: Access denied!/',
$output->getResults()[0]->getReason()
);

Expand Down

0 comments on commit 2da5ce2

Please sign in to comment.