Add Sahara data processing support #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ekasitk Is this PR ready for review? Thanks |
|
@haphan Yes, it is ready for review. |
|
Can you rebase with |
|
@haphan Rebase was done. Could you review it again? |
haphan
requested changes
Feb 15, 2018
There was a problem hiding this comment.
Hi @ekasitk, very high quality PR. Just a few comments below; mainly to follow existing standard and convention of other services in this SDK
- Add description and return types where possible (
src/DataProcessing/v1/Service.php). This will help to generate very nice reference doc. - Add unit tests
- Nice to have: integration tests.
| 'neutronManagementNetwork' => '{neutronManagementNetworkId}', | ||
| ]; | ||
|
|
||
| $cluster = $sahara->createCluster($options); |
There was a problem hiding this comment.
Add type hint to $cluster
e.g. /**@var OpenStack\DataProcessing\v1\Models\Cluster $cluster */
|
|
||
| $clusters = $sahara->createCluster($options); | ||
| foreach ($clusters as $cluster) { | ||
| print_r($cluster); |
|
|
||
| $sahara = $openstack->dataProcessingV1(['region' => '{region}']); | ||
|
|
||
| $cluster = $sahara->getCluster(['id' => '{clusterId}']); |
|
|
||
| $sahara = $openstack->dataProcessingV1(['region' => '{region}']); | ||
|
|
||
| $cluster = $sahara->getCluster(['id' => '{clusterId}']); |
| ]; | ||
|
|
||
| $clusters = $sahara->listClusters($options); | ||
| foreach ($clusters as $cluster) { |
|
|
||
| $sahara = $openstack->dataProcessingV1(['region' => '{region}']); | ||
|
|
||
| $cluster = $sahara->getCluster(['id' => '{clusterId}']); |
| 'name' => '{ClusterTemplateName}', | ||
| ]; | ||
|
|
||
| $clusterTemplate = $sahara->createClusterTemplate($options); |
| protected $resourcesKey = 'images'; | ||
|
|
||
| protected $aliases = [ | ||
| 'OS-EXT-IMG-SIZE:size' => 'OSEXTIMGSIZEsize', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the first version of sahara data processing support (ref. https://developer.openstack.org/api-ref/data-processing/).