[WIP] Add new RedisRepository #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repository is inspired by the previous implementation but uses hash maps over sets for pending messages (due to message identifiers as keys).
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-introduces the
RedisRepositorydeleted by #33, but with the newRepositoryinterface and slightly different logic.The new implementation utilizes hash maps for pending messages instead of sets. Most operations only involve one call to the Redis database, since we can use commands which terminate gracefully on failure (which we can then forward as exception or negative result to the caller).
Todos:
This PR superseeds #40 which was based on an old branch.