Google Gemini tool support #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tryvin
approved these changes
Jun 13, 2025
|
@valtzu thanks for the extraction! It's kinda hard to keep up with the updates here, as I can only contribute in my free time and I'm kinda busy lately. Hopefully this gets merged soon |
OskarStark
reviewed
Jun 15, 2025
|
Added tool calls for streams too |
chr-hertel
reviewed
Jun 15, 2025
Comment on lines
38
to
50
| return [ | ||
| ['text' => $data->content], | ||
| array_filter( | ||
| [ | ||
| 'text' => $data->content, | ||
| 'functionCall' => ($data->toolCalls[0] ?? null) ? [ | ||
| 'id' => $data->toolCalls[0]->id, | ||
| 'name' => $data->toolCalls[0]->name, | ||
| 'args' => $data->toolCalls[0]->arguments ?: new \ArrayObject(), | ||
| ] : null, | ||
| ], | ||
| static fn ($content) => null !== $content, | ||
| ), | ||
| ]; |
There was a problem hiding this comment.
isn't this the same like
$normalized = [];
if (null !== $data->content) {
$normalized['text'] = $data->content;
}
if (isset($data->toolCalls[0])) {
$normalized['functionCall'] = [
'id' => $data->toolCalls[0]->id,
'name' => $data->toolCalls[0]->name,
'args' => $data->toolCalls[0]->arguments ?: new \ArrayObject(),
];
}
return [$normalized];at least that's more readable to me
could also have a separate ToolCallNormalizer but that might be overkill
chr-hertel
requested changes
Jun 15, 2025
|
Oh, and would be great if you could add |
Co-authored-by: Vin Souza <[email protected]>
|
Should be good now |
valtzu
commented
Jun 16, 2025
| public function normalize(mixed $data, ?string $format = null, array $context = []): array | ||
| { | ||
| $parameters = $data->parameters; | ||
| unset($parameters['additionalProperties']); |
There was a problem hiding this comment.
Not sure why/if this is needed, but it was included in the original implementation by @tryvin
|
Nevermind the commit pipeline thingy ... 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tool support to Google Gemini.
Extracted from #320 with updates after #326