Skip to content

refactor: message content file handling [BC BREAK] #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

chr-hertel
Copy link
Member

@chr-hertel chr-hertel commented Apr 18, 2025

Preparation for #279

  • Introducing a base File that centralizes mime type, base64 handling, etc.
  • Image split into ImageUrl and Image based on File => i usually know what i need in user land
    • new Image('https://...') => new ImageUrl('https://...)
    • new Image('data:image/jpeg;base64,...') => Image::fromDataUrl('data:image/jpeg;base64,...')
    • new Image('/path/to/jpeg.jpg') => Image::fromFile('/path/to/jpeg.jpg')
  • removing File class of Whisper bridge in favor of Audio

@chr-hertel chr-hertel added the BC BREAK Backwards compatibility break label Apr 18, 2025
@chr-hertel chr-hertel force-pushed the refactor-file-handling branch from 746a43c to 50b6321 Compare April 18, 2025 21:31
@chr-hertel chr-hertel merged commit 99336fe into main Apr 18, 2025
7 checks passed
@chr-hertel chr-hertel deleted the refactor-file-handling branch April 18, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC BREAK Backwards compatibility break refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants