fix: allow configuration of php-http/socket-client >=2.0 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
force-pushed
the
fix-constructor-bc
branch
from
b1ceb48 to
5b003df
Compare
2 tasks
dbu
force-pushed
the
fix-constructor-bc
branch
from
5b003df to
bc10601
Compare
dbu
force-pushed
the
fix-constructor-bc
branch
from
bc10601 to
b573b9c
Compare
|
@Nyholm do you agree that this change makes sense? i think this will solve the original issue that HttplugBundle uses the version 1 signature of the constructor and therefore the $config is ignored (because its the second argument, but the bundle looks at first or 3rd argument). |
|
I dont really understand why we ever had To remove all but 1 makes sense. Im happy to deprecate it. |
|
i think some refactoring when moving from version 1 to 2 got messed up... when we go to version 3, we can remove all but the first argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrap up #62 - Allow configuration of php-http/socket-client >=2.0 with HttplugBundle
fix #62