Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynamic Component Example to Documentation #3632

Merged
merged 8 commits into from
Jan 14, 2025

Conversation

kyleboe
Copy link
Contributor

@kyleboe kyleboe commented Jan 11, 2025

Closes #3597

lib/phoenix_component.ex Outdated Show resolved Hide resolved
@SteffenDE SteffenDE requested a review from josevalim January 11, 2025 23:24
Co-authored-by: Steffen Deusch <[email protected]>
@kyleboe kyleboe requested a review from SteffenDE January 12, 2025 07:32
lib/phoenix_component.ex Outdated Show resolved Hide resolved
lib/phoenix_component.ex Outdated Show resolved Hide resolved
Co-authored-by: José Valim <[email protected]>
lib/phoenix_component.ex Outdated Show resolved Hide resolved
lib/phoenix_component.ex Outdated Show resolved Hide resolved
lib/phoenix_component.ex Outdated Show resolved Hide resolved
lib/phoenix_component.ex Show resolved Hide resolved
lib/phoenix_component.ex Outdated Show resolved Hide resolved
@kyleboe
Copy link
Contributor Author

kyleboe commented Jan 14, 2025

Thanks for the reviews! I think I have all of the suggested changes merged in now. Let me know if there's anything else that needs changing. 👍

@josevalim josevalim merged commit 8df189a into phoenixframework:main Jan 14, 2025
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic Functional Components
3 participants