Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix form submissions that wait for uploads to complete (#2865)
This fixes an issue we discovered at Felt, which was introduced in #2490. The symptoms were as follows: - Given a form with an image upload, if you waited until the upload completed before submitting the form, the submission would work as expected. - However, if you submitted before the upload completed, you'd see the submission correctly wait until the upload hit 100%, then you'd get a JavaScript crash and the app would go dead. The JavaScript console produced an error like this in release: ``` TypeError: r.hasAttribute is not a function. (In 'r.hasAttribute("name")', 'r.hasAttribute' is undefined) ``` The error in dev, of course, was more descriptive: ``` submitter.hasAttribute is not a function Call Stack serializeForm node_modules/phoenix_live_view/priv/static/phoenix_live_view.esm.js:2402:30 pushFormSubmit node_modules/phoenix_live_view/priv/static/phoenix_live_view.esm.js:3308:35 push node_modules/phoenix_live_view/priv/static/phoenix_live_view.esm.js:3293:29 triggerAwaitingSubmit node_modules/phoenix_live_view/priv/static/phoenix_live_view.esm.js:3236:7 pushInput/ node_modules/phoenix_live_view/priv/static/phoenix_live_view.esm.js:3223:18 uploadFiles/ node_modules/phoenix_live_view/priv/static/phoenix_live_view.esm.js:3325:11 initAdapterUpload/this._entries node_modules/phoenix_live_view/priv/static/phoenix_live_view.esm.js:895:16 onDone/this._onDone node_modules/phoenix_live_view/priv/static/phoenix_live_view.esm.js:769:7 progress/< node_modules/phoenix_live_view/priv/static/phoenix_live_view.esm.js:745:16 finish node_modules/phoenix_live_view/priv/static/phoenix_live_view.esm.js:3034:18 ``` Inspecting the code, it looks like the argument order got swapped in the case where uploads are in progress at form submission time. I'm not sure how to write an adequate test to cover this, but I can confirm that the fix when applied to my codebase does indeed fix the issue.
- Loading branch information