G3: Reopen G3 PR and fix implementation on latest phoenix-rtos #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: G3-79
This commit adds quick fixes to loadng (matric_type and endianess issue) discovered during tests carried out as part of the plugfest. Note: these corrections need to be considered where to apply properly because they are quick fixes for now in the meaning of temporary. JIRA: G3-88
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -590,10 +588,8 @@ static int socket_ioctl(int sock, unsigned long request, const void *in_data, vo | |||
| struct netif *netif; | |||
|
|
|||
| ifconf->ifc_len = 0; | |||
| if (!ifreq) { | |||
| /* WARN: it is legal to pass NULL here (we should return the length sufficient for whole response) */ | |||
| if (!ifreq) // WARN: it is legal to pass NULL here (we should return the lenght sufficient for whole response) | |||
There was a problem hiding this comment.
[codespell] reported by reviewdog 🐶
lenght ==> length
| uint16_t short_address; /* 2 octets (16-bit) */ | ||
| uint8_t tone_map[3]; /* 3 octets (24-bit) */ | ||
| uint8_t active_tones; | ||
| uint8_t tx_coef[6]; /* number of gain steps requseted for the tones */ |
There was a problem hiding this comment.
[codespell] reported by reviewdog 🐶
requseted ==> requested
| * containing information needed by ADP layer */ | ||
| struct g3plc_mcps_indication { | ||
| uint8_t msdu_linkquality; /* (forward) LQI value measured during reception of the message */ | ||
| uint8_t security_level; /* security level of the received message 0x00: unecrypted, 0x05: encrypted */ |
There was a problem hiding this comment.
[codespell] reported by reviewdog 🐶
unecrypted ==> unencrypted
| @@ -28,9 +28,10 @@ | |||
| #define CHAP_SUPPORT 1 | |||
| #define MSCHAP_SUPPORT 1 | |||
| #define LWIP_TIMEVAL_PRIVATE 0 | |||
| #define LWIP_IPV6 1 | |||
There was a problem hiding this comment.
[clang-format-pr] reported by reviewdog 🐶
suggested fix
Suggested change
| #define LWIP_IPV6 1 | |
| #define LWIP_IPV6 1 |
|
|
||
|
|
||
| #if 0 // debugging LWiP PPPoS | ||
| #if 1 // debugging LWiP PPPoS |
There was a problem hiding this comment.
[clang-format-pr] reported by reviewdog 🐶
suggested fix
Suggested change
| #if 1 // debugging LWiP PPPoS | |
| #if 1 // debugging LWiP PPPoS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've rebased changes from plugfest tag and fixed issues found on the latest phoenix-rtos.
Types of changes
How Has This Been Tested?
Checklist:
Special treatment