Skip to content

imx6ull-flash: add function for checking DMA descriptor chain #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

imx6ull-flash: add function for checking DMA descriptor chain #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions storage/imx6ull-flash/flashdrv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* %LICENSE%
*/

#include <assert.h>
#include <errno.h>
#include <unistd.h>
#include <stdint.h>
Expand Down Expand Up @@ -459,6 +460,32 @@ void flashdrv_dmadestroy(flashdrv_dma_t *dma)
}


static dma_t *dma_verify(dma_t *desc)
{
/* DMA transfer/sense, check the buffer */
if ((desc->flags & 3) && (desc->buffer == 0)) {
printf("imx6ull-flash: detected NULL buffer for DMA transfer!\n");
}

/* Return next descriptor */
return (desc->flags & dma_chain) ? (dma_t *)((uintptr_t)desc + (desc->next - (uint32_t)va2pa(desc))) : NULL;
}


static int flashdrv_dmaverify(flashdrv_dma_t *dma)
{
dma_t *desc = dma->first;
int n = 0;

while (desc != NULL) {
desc = dma_verify(desc);
n++;
}

return n;
}


int flashdrv_wait4ready(flashdrv_dma_t *dma, int chip, int err)
{
void *next = dma->last, *prev = dma->last;
Expand Down Expand Up @@ -652,6 +679,8 @@ int flashdrv_reset(flashdrv_dma_t *dma)
flashdrv_issue(dma, flash_reset, chip, NULL, 0, NULL, NULL);
flashdrv_finish(dma);

assert(flashdrv_dmaverify(dma) == 2);

mutexLock(flashdrv_common.mutex);
flashdrv_common.result = 1;
dma_run((dma_t *)dma->first, channel);
Expand Down Expand Up @@ -684,6 +713,8 @@ int flashdrv_readid(flashdrv_dma_t *dma, flash_id_t *flash_id)
flashdrv_wait4ready(dma, chip, EOK);
flashdrv_finish(dma);

assert(flashdrv_dmaverify(dma) == 10);

mutexLock(flashdrv_common.mutex);
flashdrv_common.result = 1;
dma_run((dma_t *)dma->first, channel);
Expand Down Expand Up @@ -728,6 +759,8 @@ int flashdrv_write(flashdrv_dma_t *dma, uint32_t paddr, void *data, char *aux)
flashdrv_readcompare(dma, chip, 0x3, 0, -1);
flashdrv_finish(dma);

assert(flashdrv_dmaverify(dma) == 11);

mutexLock(flashdrv_common.mutex);

if (data == NULL) {
Expand Down Expand Up @@ -794,6 +827,8 @@ int flashdrv_read(flashdrv_dma_t *dma, uint32_t paddr, void *data, flashdrv_meta
flashdrv_disablebch(dma, chip);
flashdrv_finish(dma);

assert(flashdrv_dmaverify(dma) == 9);

mutexLock(flashdrv_common.mutex);
flashdrv_common.result = 1;
flashdrv_common.bch_done = 0;
Expand Down Expand Up @@ -827,6 +862,8 @@ int flashdrv_erase(flashdrv_dma_t *dma, uint32_t paddr)
flashdrv_readcompare(dma, chip, 0x1, 0, -1);
flashdrv_finish(dma);

assert(flashdrv_dmaverify(dma) == 10);

mutexLock(flashdrv_common.mutex);
flashdrv_common.result = 1;
dma_run((dma_t *)dma->first, channel);
Expand Down Expand Up @@ -859,6 +896,8 @@ int flashdrv_writeraw(flashdrv_dma_t *dma, uint32_t paddr, void *data, int sz)
flashdrv_readcompare(dma, 0, 0x3, 0, -1);
flashdrv_finish(dma);

assert(flashdrv_dmaverify(dma) == 11);

mutexLock(flashdrv_common.mutex);
flashdrv_common.result = 1;
dma_run((dma_t *)dma->first, channel);
Expand Down Expand Up @@ -892,6 +931,8 @@ int flashdrv_readraw(flashdrv_dma_t *dma, uint32_t paddr, void *data, int sz)
flashdrv_wait4ready(dma, chip, EOK);
flashdrv_finish(dma);

assert(flashdrv_dmaverify(dma) == 11);

mutexLock(flashdrv_common.mutex);
flashdrv_common.result = 1;
dma_run((dma_t *)dma->first, channel);
Expand Down Expand Up @@ -930,6 +971,8 @@ int flashdrv_isbad(flashdrv_dma_t *dma, uint32_t paddr)
flashdrv_wait4ready(dma, chip, EOK);
flashdrv_finish(dma);

assert(flashdrv_dmaverify(dma) == 11);

mutexLock(flashdrv_common.mutex);
flashdrv_common.result = 1;
dma_run((dma_t *)dma->first, channel);
Expand Down Expand Up @@ -971,6 +1014,8 @@ int flashdrv_markbad(flashdrv_dma_t *dma, uint32_t paddr)
flashdrv_readcompare(dma, 0, 0x3, 0, -1);
flashdrv_finish(dma);

assert(flashdrv_dmaverify(dma) == 11);

mutexLock(flashdrv_common.mutex);

memset(data, 0xff, flashdrv_common.info.writesz + flashdrv_common.info.metasz);
Expand Down