Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safe values should be raw #792

Merged
merged 3 commits into from
Oct 1, 2024
Merged

safe values should be raw #792

merged 3 commits into from
Oct 1, 2024

Conversation

Vagab
Copy link
Contributor

@Vagab Vagab commented Sep 25, 2024 •
edited
Loading

@joeldrapper @willcosgrove
so I made html_safe and safe consistent in this pr and also created __implicit_output__ and made plain use old __text__ instead so we can render html_safe as raw by default, unless it's plain. Does that look good?

@Vagab Vagab marked this pull request as ready for review September 25, 2024 13:37
@Vagab Vagab changed the title draft safe values should be raw Sep 25, 2024
@Vagab
Copy link
Contributor Author

Vagab commented Sep 26, 2024 •
edited
Loading

@joeldrapper @willcosgrove does this pr look like something you want? Or should I rollback the change to __implicit_output__ that allows to pass safe into a component without raw on the other side, and instead just fix the order in elements.rb?

@Vagab
Copy link
Contributor Author

Vagab commented Sep 30, 2024

@joeldrapper ping

@joeldrapper joeldrapper merged commit afafc0e into phlex-ruby:main Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vagab @joeldrapper