CI: Use stable version of Quickdraw #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But, also add a separate job that runs with edge version of Quickdraw.
bquorning
force-pushed
the
use-stable-quickdraw-version-for-ci
branch
from
885837d to
5c44705
Compare
|
Finding a stable version of Quickdraw and fixing the Phlex tests was a bit harder than anticipated. But it seems to work now (apart from the truffleruby-23.1 error which I haven’t looked into). |
bquorning
force-pushed
the
use-stable-quickdraw-version-for-ci
branch
from
e500af1 to
64b06e9
Compare
bquorning
force-pushed
the
use-stable-quickdraw-version-for-ci
branch
from
64b06e9 to
1e71492
Compare
bquorning
commented
Jul 5, 2024
| output = grab({ class: "foo" }) | ||
| expect(output) == ["foo"] | ||
| output = grab(class: "foo") | ||
| expect(output) == "foo" |
There was a problem hiding this comment.
I am unsure about this change. Is it intentional that #grab sometimes returns an Array and sometimes a String?
|
I will be unable to work on this PR for the next week or so. @joeldrapper If you feel like it, please take over and change it as you like. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But, also add a separate job that runs with edge version of Quickdraw.
Some tests were failing because they had no expectation (I added one), and some were failing because they didn’t match the implementation (I changed the tests to match).