Lets go #703
Merged
Lets go #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldrapper
commented
Apr 6, 2024
Comment on lines
+17
to
+18
| - "truffleruby-23.1" | ||
| - "truffleruby-24.0" |
There was a problem hiding this comment.
These are 3.2 and 3.3 compatible.
joeldrapper
commented
Apr 6, 2024
| to_s | ||
| end | ||
| end | ||
| SUPPORTS_FIBER_STORAGE = RUBY_ENGINE == "ruby" |
There was a problem hiding this comment.
TruffleRuby doesn’t support Fiber#[] at the moment.
joeldrapper
commented
Apr 6, 2024
Comment on lines
-102
to
-108
| if deprecated | ||
| deprecation = <<~RUBY | ||
| Kernel.warn "#{deprecated}" | ||
| RUBY | ||
| else | ||
| deprecation = "" | ||
| end |
There was a problem hiding this comment.
We're not going to need to use this for a while, so may as well get rid of it.
joeldrapper
commented
Apr 6, 2024
| @@ -7,7 +7,7 @@ class HTML < SGML | |||
| autoload :VoidElements, "phlex/html/void_elements" | |||
|
|
|||
| # A list of HTML attributes that have the potential to execute unsafe JavaScript. | |||
| EVENT_ATTRIBUTES = %w[onabort onafterprint onbeforeprint onbeforeunload onblur oncanplay oncanplaythrough onchange onclick oncontextmenu oncopy oncuechange oncut ondblclick ondrag ondragend ondragenter ondragleave ondragover ondragstart ondrop ondurationchange onemptied onended onerror onfocus onhashchange oninput oninvalid onkeydown onkeypress onkeyup onload onloadeddata onloadedmetadata onloadstart onmessage onmousedown onmousemove onmouseout onmouseover onmouseup onmousewheel onoffline ononline onpagehide onpageshow onpaste onpause onplay onplaying onpopstate onprogress onratechange onreset onresize onscroll onsearch onseeked onseeking onselect onstalled onstorage onsubmit onsuspend ontimeupdate ontoggle onunload onvolumechange onwaiting onwheel].to_h { [_1, true] }.freeze | |||
| EVENT_ATTRIBUTES = Set.new(%w[onabort onafterprint onbeforeprint onbeforeunload onblur oncanplay oncanplaythrough onchange onclick oncontextmenu oncopy oncuechange oncut ondblclick ondrag ondragend ondragenter ondragleave ondragover ondragstart ondrop ondurationchange onemptied onended onerror onfocus onhashchange oninput oninvalid onkeydown onkeypress onkeyup onload onloadeddata onloadedmetadata onloadstart onmessage onmousedown onmousemove onmouseout onmouseover onmouseup onmousewheel onoffline ononline onpagehide onpageshow onpaste onpause onplay onplaying onpopstate onprogress onratechange onreset onresize onscroll onsearch onseeked onseeking onselect onstalled onstorage onsubmit onsuspend ontimeupdate ontoggle onunload onvolumechange onwaiting onwheel]).freeze | |||
There was a problem hiding this comment.
Using a Set here seems to be just as fast as a Hash of true values.
joeldrapper
commented
Apr 6, 2024
| register_element :template_tag, tag: "template" | ||
| register_element :template |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #687
Closes #632