Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the <param> element #632

Closed
2 tasks
joeldrapper opened this issue Jan 30, 2024 · 2 comments · Fixed by #703
Closed
2 tasks

Remove the <param> element #632

joeldrapper opened this issue Jan 30, 2024 · 2 comments · Fixed by #703
Labels
breaking
Milestone
2.0

Comments

@joeldrapper
Copy link
Collaborator

joeldrapper commented Jan 30, 2024 •
edited
Loading

  • Issue a warning in 1.x
  • Remove in 2.0
@joeldrapper joeldrapper added this to the 2.0 milestone Jan 30, 2024
@stephannv
Copy link
Contributor

stephannv commented Feb 1, 2024 •
edited
Loading

First item solved by: #642

@joeldrapper
Copy link
Collaborator Author

joeldrapper commented Feb 2, 2024 •
edited
Loading

@stephannv That deprecated: true argument is just a no-op at the moment. We need to update the generated elemen method to issue a warning if that flag is set.

@stephannv stephannv mentioned this issue Feb 2, 2024
Closed
@joeldrapper joeldrapper mentioned this issue Apr 6, 2024
Merged
joeldrapper added a commit that referenced this issue Apr 6, 2024
@joeldrapper
Lets go (#703)
31553f4 
Closes #687 
Closes #632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Lets go phlex-ruby/phlex
2 participants
@joeldrapper @stephannv