Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak FreeBSD workflow after a package rename #175

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Feb 20, 2025

Similar to labwc/labwc#2589 but wlmaker uses /quarterly set, so CI wouldn't be affected until around 2025-04-01.

I put my patches here into the public domain. CLA isn't an option for me due to lacking a Google Account which cannot be signed up for via Tor. Feel free to resubmit under differnt authorship (e.g., git commit --amend --reset-author) in order to satisfy CLA.

Helps to get newer wayland-protocols, (lib)wayland and wlroots sooner,
without waiting for a new /quarterly cut.
Copy link

google-cla bot commented Feb 20, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@phkaeser
Copy link
Owner

The github workflow fails (yet) -- does the "version" also need a bump?

https://github.com/phkaeser/wlmaker/actions/runs/13426090338/job/37517631296?pr=175

@jbeich
Copy link
Contributor Author

jbeich commented Feb 20, 2025

Waiting for the package set to build.

@phkaeser
Copy link
Owner

Oh, sorry for the impatience here! 😄

@jbeich jbeich marked this pull request as ready for review February 21, 2025 18:19
@jbeich
Copy link
Contributor Author

jbeich commented Feb 21, 2025

Should be ready to land. Not sure how to re-trigger CI without force push.

@phkaeser
Copy link
Owner

For whatever reason, the workflows need maintainer approval (?). Anyway, that's a simple click :)

Thanks for preparing wlmaker for the package change!

@phkaeser phkaeser merged commit 5986f35 into phkaeser:main Feb 21, 2025
7 of 8 checks passed
phkaeser added a commit that referenced this pull request Feb 22, 2025
* Switch FreeBSD to more frequently updated packages

Helps to get newer wayland-protocols, (lib)wayland and wlroots sooner,
without waiting for a new /quarterly cut.

* Chase wlroots package rename on FreeBSD

freebsd/freebsd-ports@2cb7175c921d

---------

Co-authored-by: Philipp Kaeser <[email protected]>
phkaeser added a commit that referenced this pull request Feb 23, 2025
* Initial check-in for submenu.

* Fix compilation errors and show the submenu hack.

* Centralizes menu state operations. (#177)

* Unbreak FreeBSD workflow after a package rename (#175)

* Switch FreeBSD to more frequently updated packages

Helps to get newer wayland-protocols, (lib)wayland and wlroots sooner,
without waiting for a new /quarterly cut.

* Chase wlroots package rename on FreeBSD

freebsd/freebsd-ports@2cb7175c921d

---------

Co-authored-by: Philipp Kaeser <[email protected]>

* Updates wlmtk_submenu_t to using it's item in composed fashion.

* Adds wlmtk_menu_item_get_state and state_changed signal.

* Tests the data_ptr arg.

* Shows or hides submenu, depending on item state.

* Eliminates submenu 'triggered' handler for now.

* Take some thoughts on menu, windows and submenu.

* Clean up for doxygen completeness and hide submenu for time being.

---------

Co-authored-by: Jan Beich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants