Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to tree_magic_mini fork #66

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Conversation

mbrubeck
Copy link
Contributor

This removes several old crates from the dependency graph.

@phiresky
Copy link
Owner

Do you have some more info about that fork?

@mbrubeck
Copy link
Contributor Author

I created this fork based on the tree_magic master branch, with one commit reverted to fix compiler errors. I included my pull request to upgrade to nom 5.1, aahancoc/tree_magic#20.

I also included some optimizations and cleanups that I found while doing the nom 5 upgrade, and removed some optional code to simplify and shrink the library. From the README:

This is a fork of the tree_magic crate by Allison Hancock. It includes the following changes:

  • Updated dependencies.
  • Reduced copying and memory allocation, for a slight increase in speed and
    decrease in memory use.
  • Reduced API surface. Some previously public APIs are now internal.
  • Removed the optional cli feature and tmagic binary.

These changes were made both to make the library more efficient, and to simplify the effort to maintain and optimize of this fork. I would like to eventually merge these changes back to the original tree_magic crate, and/or restore some of the removed features if there is demand for that.

I've also offered to help maintain the original tree_magic at aahancoc/tree_magic#16.

@phiresky
Copy link
Owner

Sounds good

@phiresky phiresky merged commit 5ef161e into phiresky:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants