Add support for headers and dynamic base URL (#65) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sliiser
commented
Jun 25, 2024
sliiser
commented
Jun 25, 2024
philss
reviewed
Jun 27, 2024
sliiser
force-pushed
the
dynamic-base-url-and-headers
branch
from
dc6fa8b
to
88c8feb
Compare
|
@sliiser almost there! There is one problem in the tests, but other than that it looks great! Please take a look. |
The :base_url attribute now accepts static headers or a custom function that returns a URL and headers. This allows us to fetch NIFs from more complicated sources, rather than just public GitHub releases. Co-authored-by: Philip Sampaio <[email protected]>
sliiser
force-pushed
the
dynamic-base-url-and-headers
branch
from
88c8feb
to
3bcb29a
Compare
|
Whoops. That test was linux only so it didn't fail on my dev machine. Fixed now (hopefully). I also squashed the commits to be ready for merge. |
|
Hey, it's been a while... Anything else you need me to change here? |
Co-authored-by: Philip Sampaio <[email protected]>
Previously the `RustlerPrecompiled.Config` struct was initialized directly in the tests, which bypassed the validation in `new/1`. This change updates the tests to use `new/1` wherever possible. Some tests still use direct struct access to test invalid values.
|
@sliiser this is great! Thank you! I should release a new version today. I will ping you here. |
philss
added a commit
that referenced
this pull request
Aug 28, 2024
philss
added a commit
that referenced
this pull request
Aug 28, 2024
|
@sliiser it's released under v0.8.0. Please give it a try. |
|
Oh, sorry for not reporting back earlier. Works great! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The :base_url attribute now accepts static headers or a custom function that returns a URL and headers. This allows us to fetch NIFs from more complicated sources, rather than just public GitHub releases.
#65