Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fallback/stdio build #196

Merged
merged 2 commits into from
Jan 20, 2025
Merged

fix fallback/stdio build #196

merged 2 commits into from
Jan 20, 2025

Conversation

guberathome
Copy link
Contributor

@guberathome guberathome commented Jan 5, 2025 •
edited
Loading

Fixes the build issue #195 on {MSYS2, Linux, FreeBSD, NetBSD}.

Test on Linux, FreeBSD are now ok:

$ IO_SOURCE="pf_io_stdio.c pf_fileio_stdio.c" make test
...
Standalone pForth executable written to pforth_standalone
cd ../../fth && /home/siggi/build/vanilla/pforth-2.0.1/platforms/unix/pforth_standalone -q t_corex.fth
...
 124 passed,    0 failed.
cd ../../fth && /home/siggi/build/vanilla/pforth-2.0.1/platforms/unix/pforth_standalone -q t_strings.fth
...
  58 passed,    0 failed.
cd ../../fth && /home/siggi/build/vanilla/pforth-2.0.1/platforms/unix/pforth_standalone -q t_locals.fth
...
   9 passed,    0 failed.
cd ../../fth && /home/siggi/build/vanilla/pforth-2.0.1/platforms/unix/pforth_standalone -q t_alloc.fth
...
   1 passed,    0 failed.
cd ../../fth && /home/siggi/build/vanilla/pforth-2.0.1/platforms/unix/pforth_standalone -q t_floats.fth
...
  60 passed,    0 failed.
cd ../../fth && /home/siggi/build/vanilla/pforth-2.0.1/platforms/unix/pforth_standalone -q t_file.fth
...
  94 passed,    0 failed.
PForth Tests PASSED

MSYS2 still fails on RESIZE-FILE.
Tests for FILE-RESIZE fails on NetBSD, which should probably be treated as separate issue.

@guberathome guberathome changed the title fix fallback/stdio build (#195) fix fallback/stdio build Jan 5, 2025
@guberathome guberathome marked this pull request as ready for review January 6, 2025 08:02
@guberathome
Copy link
Contributor Author

ready to be merged.

@guberathome
Copy link
Contributor Author

Update: Verify that this fixes the NetBSD problems as well after #198 has been merged.

@guberathome guberathome mentioned this pull request Jan 17, 2025
Open
philburk
philburk approved these changes Jan 20, 2025
View reviewed changes
Copy link
Owner

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

csrc/stdio/pf_io_stdio.c Show resolved Hide resolved
@philburk philburk merged commit 9db4e9e into philburk:master Jan 20, 2025
3 checks passed
@guberathome guberathome deleted the stdio-build branch January 22, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philburk philburk philburk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guberathome @philburk