Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Wave Interference variant where each screen is a different wave type #356

Closed
samreid opened this issue Mar 24, 2019 · 11 comments
Closed

Comments

@samreid
Copy link
Member

samreid commented Mar 24, 2019

From my notes from Thursday's status meeting:

  • We would like to create a basic waves sim, with one screen for each scene.
  • I could start on that without too much more design work.
  • New repo "waves" or "Waves: Basics"--email with @arouinfar to come up with a name.
  • It would be good to get started on this.

This idea is also mentioned in the design meeting notes from February 19, 2019.

I'd like to finalize the sim name before creating the repo. But I can start prototyping it in the wave-interference repo (perhaps with query parameters) before we create the repo.

@samreid samreid self-assigned this Mar 24, 2019
@samreid
Copy link
Member Author

samreid commented Mar 24, 2019

Is this supposed to be based on the "waves" screen of Wave Interference, with neither slits nor multiple source?

@arouinfar
Copy link
Contributor

@samreid there hasn't been any design work beyond the one brainstorming meeting.

The sim would only include the Waves screen of Wave Interference. Instead of three scenes (one for each wave type), we would have three screens -- Water, Sound, and Light. I would say a first pass at implementation would be to split the Waves screen into these three separate screens, but we would really need to have more design discussions before taking things any further.

@arouinfar arouinfar removed their assignment Mar 24, 2019
@samreid
Copy link
Member Author

samreid commented Mar 25, 2019

In the preceding commit, I created a rough draft for the simulation, you can see it on phettest at:
http://phettest.colorado.edu/wave-interference/wave-interference_en.html?ea&brand=phet&mediumScreens

I'll create issues for some follow-up work/questions.

@samreid
Copy link
Member Author

samreid commented Mar 25, 2019

The main work is done, I noted 2 issues above. Reassigning to @arouinfar for other feedback on this rough draft.

@arouinfar
Copy link
Contributor

Thanks @samreid! Could you publish this as a dev version instead? The VPN is super sluggish here.

@samreid
Copy link
Member Author

samreid commented Mar 25, 2019

I'm happy to create a new dev version, but suffering from the problem described in https://github.com/phetsims/special-ops/issues/133, so cannot easily create dev versions at the moment. I'll keep you posted.

@samreid
Copy link
Member Author

samreid commented Mar 25, 2019

@samreid samreid removed their assignment Mar 25, 2019
@arouinfar
Copy link
Contributor

Thanks @zepumph!

@samreid everything's looking good. I don't have any further suggestions for now, but this will be useful when discussing the big picture in design meeting.

@samreid
Copy link
Member Author

samreid commented Apr 4, 2019

Other than the screen icons, we need to address the patterns on the light screen accumulator (would prefer no interference pattern), which is tracked in #349

@samreid will also publish a dev version for review.

@samreid samreid self-assigned this Apr 4, 2019
@samreid
Copy link
Member Author

samreid commented Apr 5, 2019

Here's an initial dev version:
https://phet-dev.colorado.edu/html/waves-intro/1.0.0-dev.1/phet/waves-intro_en_phet.html

@arouinfar anything else for this issue?

@samreid samreid assigned arouinfar and unassigned samreid Apr 5, 2019
@arouinfar
Copy link
Contributor

@arouinfar anything else for this issue?

Don't think so! I'll go ahead and close, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants