Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we eliminate the separator in the control panel? #359

Closed
samreid opened this issue Mar 25, 2019 · 2 comments
Closed

Should we eliminate the separator in the control panel? #359

samreid opened this issue Mar 25, 2019 · 2 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Mar 25, 2019

As part of #356 I'm wondering if we should eliminate the separator in the control panel.

image

image

image

@arouinfar
Copy link
Contributor

@samreid I think the separator line helps keep the sliders and other UI controls separate. For water especially, I think the line draws attention to the check box, which could be overlooked. Another option would be to separate the controls into two separate panels, but I think that would look pretty odd for water, which just has the one checkbox.

If you'd like to discuss further in design meeting @samreid, please go ahead and tag it .

@arouinfar arouinfar assigned samreid and unassigned arouinfar Mar 25, 2019
@samreid
Copy link
Member Author

samreid commented Mar 25, 2019

My initial instinct was this looked odd, but I agree there are good reasons to keep it. Let's close this issue.

@samreid samreid closed this as completed Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants