Increase damping coefficient and use gradual reduction for masking, see

#304
phetsims · Jan 8, 2019 · 5c47f1e · 5c47f1e
1 parent 178aba4
commit 5c47f1e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/js/common/model/Lattice.js b/js/common/model/Lattice.js
@@ -22,7 +22,7 @@ define( require => {
   const WAVE_SPEED = 0.5;
   const WAVE_SPEED_SQUARED = WAVE_SPEED * WAVE_SPEED; // precompute to avoid work in the inner loop
   const NUMBER_OF_MATRICES = 3; // The discretized wave equation algorithm requires current value + 2 history points
-  const DAMPING_COEFFICIENT = 0.999; // wave values scaled by this much at each frame to wash out numerical artifacts
+  const DAMPING_COEFFICIENT = 0.9999; // wave values scaled by this much at each frame to wash out numerical artifacts
 
   // This is the threshold for the wave value that determines if the light has visited.  If the value is higher,
   // it will track the wavefront of the light more accurately (and hence could be used for more accurate computation of
@@ -193,9 +193,9 @@ define( require => {
      * @param {number} j
      * @public
      */
-    clearCell( i, j ) {
+    reduceCell( i, j ) {
       for ( let k = 0; k < NUMBER_OF_MATRICES; k++ ) {
-        this.matrices[ k ].set( i, j, 0.0 );
+        this.matrices[ k ].set( i, j, this.matrices[ k ].get( i, j ) * 0.95 );
       }
       this.visitedMatrix.set( i, j, 0 );
     }

diff --git a/js/common/model/Scene.js b/js/common/model/Scene.js
@@ -618,7 +618,7 @@ define( require => {
           const cameFrom2 = this.temporalMask2.matches( i, j, this.stepIndex );
 
           if ( !cameFrom1 && !cameFrom2 ) {
-            this.lattice.clearCell( i, j );
+            this.lattice.reduceCell( i, j );
           }
         }
       }

diff --git a/js/common/model/TemporalMask.js b/js/common/model/TemporalMask.js
@@ -70,8 +70,9 @@ define( require => {
           const theoreticalTime = time - distance / Lattice.WAVE_SPEED;
 
           // if theoreticalDistance matches any time in this range, then we have a winner
-          const tolerance = 4;
-          if ( theoreticalTime >= startTime - tolerance && theoreticalTime <= endTime + tolerance ) {
+          const headTolerance = 4;
+          const tailTolerance = 4;
+          if ( theoreticalTime >= startTime - headTolerance && theoreticalTime <= endTime + tailTolerance ) {
 
             // Return as early as possible to improve performance
             return true;