Skip to content

Commit

Permalink
Fix temporal mask tail for pulse, see #300
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Jan 5, 2019
1 parent c185494 commit 48bc1c7
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions js/common/model/Scene.js
Original file line number Diff line number Diff line change
Expand Up @@ -574,8 +574,7 @@ define( require => {
if ( this.pulseFiringProperty.get() ) {
const timeSincePulseStarted = this.timeProperty.value - this.pulseStartTime;

// For 50% longer than one pulse, keep the oscillator fixed at 0 to prevent "ringing"
if ( timeSincePulseStarted > period * 1.5 ) {
if ( timeSincePulseStarted > period ) {
this.pulseFiringProperty.set( false );
this.pulseStartTime = 0;
}
Expand Down

0 comments on commit 48bc1c7

Please sign in to comment.