Pass model properties instead of model, see #289

phetsims · Jan 1, 2019 · 139e258 · 139e258
1 parent 277ef9a
commit 139e258
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/js/slits/view/SlitsScreenView.js b/js/slits/view/SlitsScreenView.js
@@ -73,7 +73,7 @@ define( require => {
 
       // When enabled by a query parameter, show the theoretical interference pattern.
       if ( WaveInterferenceQueryParameters.theory ) {
-        this.addChild( new TheoryInterferenceOverlay( model, this.waveAreaNode.bounds, {
+        this.addChild( new TheoryInterferenceOverlay( model.sceneProperty, model.scenes, this.waveAreaNode.bounds, {
           clipArea: Shape.bounds( this.waveAreaNode.bounds )
         } ) );
       }

diff --git a/js/slits/view/TheoryInterferenceOverlay.js b/js/slits/view/TheoryInterferenceOverlay.js
@@ -26,19 +26,20 @@ define( require => {
   class TheoryInterferenceOverlay extends Node {
 
     /**
-     * @param {SlitsModel} model
+     * @param {Property.<Scene>} sceneProperty
+     * @param {Scene[]} scenes
      * @param {Bounds2} viewBounds - the area where the lattice appears
      * @param {Object} [options]
      */
-    constructor( model, viewBounds, options ) {
+    constructor( sceneProperty, scenes, viewBounds, options ) {
       super( options );
 
       const updateLines = () => {
         this.removeAllChildren();
-        const barrierType = model.sceneProperty.value.barrierTypeProperty.get();
+        const barrierType = sceneProperty.value.barrierTypeProperty.get();
         if ( barrierType !== BarrierTypeEnum.NO_BARRIER ) {
 
-          const scene = model.sceneProperty.value;
+          const scene = sceneProperty.value;
           this.modelViewTransform = ModelViewTransform2.createRectangleMapping( scene.getWaveAreaBounds(), viewBounds );
 
           const barrierY = viewBounds.centerY;
@@ -113,8 +114,8 @@ define( require => {
         }
       };
 
-      model.sceneProperty.link( updateLines );
-      model.scenes.forEach( scene => {
+      sceneProperty.link( updateLines );
+      scenes.forEach( scene => {
 
         // When any of the relevant physical Properties change, update the lines.
         scene.barrierTypeProperty.link( updateLines );