Should Dialog have a "tapToClose" option?

[samreid]

During phetsims/molecules-and-light#185 @zepumph and I noticed that Molecules and Light has a feature where tapping the dialog dismisses it:

// close it on a click
var self = this;
var buttonListener = new ButtonListener( {
  fire: self.hide.bind( self )
} );
this.addInputListener( buttonListener );

Should this feature be in SUN/Dialog? Alternatively, should we remove this feature from Molecules and Light?

[pixelzoom]

No, I don't think this should be support by Dialog. Standard behavior should be:
(1) click the close button to close the dialog
(2) clicking anywhere outside the dialog is the same as clicking the close button

Yes, I would remove this feature from MAL.

[jessegreenberg]

I also vote to remove this, I think it is odd to close a dialog by clicking inside of it.

But I see those exact lines in FluorescentCellsPictureDialog (gene-expression-essentials), AboutDialog, UpdateDialog, and EnergyGraphNode (MAS), so it should be removed from all of those.

@ariel-phet are you OK with removing this from all of those dialogs?

[ariel-phet]

@jessegreenberg I am OK with removing from all those dialogs

[jessegreenberg]

OK, this has been removed from the Dialogs mentioned in #427 (comment). @samreid is there anything more to do for this issue?

[samreid]

@jessegreenberg what's this occurrence in KeyboardHelpDialog? I'm not familiar with "click":

    // @private (a11y) - input listener for the close button, must be disposed
    var clickListener = {
      click: function() {
        self.hide();
        self.focusActiveElement();
      }
    };
    this.addInputListener( clickListener );

[samreid]

@pixelzoom I found 2 more occurrences like this in Equality Explorer: in OopsDialog and InfoDialog:

    // Click anywhere on the dialog to hide it.
    this.addInputListener( new ButtonListener( {
      fire: function() { self.hide(); }
    } ) );

Would you like me to remove them?

Also a heads-up that hide might get changed to setVisible(false) as part of #369 (comment)

[pixelzoom]

Remove from Equality Explorer in the above commit.

[jessegreenberg]

Thanks @samreid, removed #427 (comment). click is the event when a button is clicked. This was added when KeyboardHelpDialog had a custom close button, but now it uses the one in Dialog.

[samreid]

Looks great, thanks! I can't find any other occurrences of this pattern, closing.