Skip to content

Commit

Permalink
UpdateDialog can't be closed on click, see phetsims/sun#427
Browse files Browse the repository at this point in the history
  • Loading branch information
jessegreenberg committed Jan 4, 2019
1 parent abaf639 commit 576c200
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions js/UpdateDialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ define( function( require ) {
'use strict';

// modules
var ButtonListener = require( 'SCENERY/input/ButtonListener' );
var Dialog = require( 'SUN/Dialog' );
var inherit = require( 'PHET_CORE/inherit' );
var joist = require( 'JOIST/joist' );
Expand Down Expand Up @@ -90,17 +89,6 @@ define( function( require ) {
// a11y
focusOnCloseNode: phetButton
} );

// close it on a click
var buttonListener = new ButtonListener( {
fire: self.hide.bind( self )
} );
this.addInputListener( buttonListener );

// @private - to be called by dispose()
this.disposeUpdateDialog = function() {
self.removeInputListener( buttonListener );
};
}

joist.register( 'UpdateDialog', UpdateDialog );
Expand Down Expand Up @@ -148,15 +136,6 @@ define( function( require ) {
timer.removeListener( this.updateStepListener );
}
}
},

/**
* Dispose the UpdateDialog so that it is eligible for garbage collection.
* @public
*/
dispose: function() {
this.disposeUpdateDialog();
Dialog.prototype.dispose.call( this );
}
} );
} );

0 comments on commit 576c200

Please sign in to comment.