Addressing code review comments, see #109

phetsims · Feb 24, 2025 · a94ba38 · a94ba38
1 parent 3d900a2
commit a94ba38
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/js/bloch-sphere/model/BlochSphereModel.ts b/js/bloch-sphere/model/BlochSphereModel.ts
@@ -9,6 +9,7 @@
  */
 
 import BooleanProperty from '../../../../axon/js/BooleanProperty.js';
+import EnumerationProperty from '../../../../axon/js/EnumerationProperty.js';
 import Multilink from '../../../../axon/js/Multilink.js';
 import NumberProperty from '../../../../axon/js/NumberProperty.js';
 import Property from '../../../../axon/js/Property.js';
@@ -91,9 +92,8 @@ class BlochSphereModel implements TModel {
       tandem: preparationAreaTandem.createTandem( 'preparationBlochSphere' )
     } );
 
-    this.selectedStateDirectionProperty = new Property( StateDirection.X_PLUS, {
+    this.selectedStateDirectionProperty = new EnumerationProperty( StateDirection.X_PLUS, {
       tandem: preparationAreaTandem.createTandem( 'selectedStateDirectionProperty' ),
-      phetioValueType: EnumerationIO( StateDirection ),
       phetioFeatured: true
     } );
 
@@ -118,9 +118,8 @@ class BlochSphereModel implements TModel {
     } );
 
     // Selected Equation Basis
-    this.equationBasisProperty = new Property( StateDirection.Z_PLUS, {
+    this.equationBasisProperty = new EnumerationProperty( StateDirection.Z_PLUS, {
       tandem: measurementAreaTandem.createTandem( 'equationBasisProperty' ),
-      phetioValueType: EnumerationIO( StateDirection ),
       phetioFeatured: true,
       validValues: QuantumMeasurementConstants.plusDirections
     } );

diff --git a/js/bloch-sphere/view/BlochSphereMeasurementArea.ts b/js/bloch-sphere/view/BlochSphereMeasurementArea.ts
@@ -247,6 +247,7 @@ export default class BlochSphereMeasurementArea extends Node {
       align: 'left',
       tandem: measurementControlsTandem,
       children: [
+        // The panel contains multiple sections for a specific control and smaller spacing. Title and component
         new VBox( {
           spacing: boxSpacing,
           children: [
@@ -255,6 +256,7 @@ export default class BlochSphereMeasurementArea extends Node {
           ],
           tandem: numberOfAtomsControlTandem
         } ),
+
         new VBox( {
           spacing: boxSpacing,
           children: [
@@ -263,6 +265,7 @@ export default class BlochSphereMeasurementArea extends Node {
           ],
           tandem: measurementAxisControlTandem
         } ),
+
         new VBox( {
           spacing: boxSpacing,
           children: [

diff --git a/js/common/view/BlochSphereNode.ts b/js/common/view/BlochSphereNode.ts
@@ -160,7 +160,7 @@ export default class BlochSphereNode extends Node {
       bottom: upStateLabel.top - 10,
       centerX: upStateLabel.centerX
     } );
-    QuantumMeasurementStrings.blochSphereStringProperty.link( () => {
+    title.boundsProperty.link( () => {
       title.centerX = upStateLabel.centerX;
     } );