address some review comments, see #109

phetsims · Feb 26, 2025 · 50c67ab · 50c67ab
1 parent 54df716
commit 50c67ab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/js/photons/model/Photon.ts b/js/photons/model/Photon.ts
@@ -22,11 +22,6 @@ export const DOWN = new Vector2( 0, -1 );
 export const LEFT = new Vector2( -1, 0 );
 export const RIGHT = new Vector2( 1, 0 );
 
-// Due to the experiment's nature, when photons are split,
-// the resulting states will either be measured as vertical or horizontal.
-// REVIEW: Unused
-export type PossiblePolarizationResult = 'vertical' | 'horizontal';
-
 class Photon {
 
   // the angle of polarization for this photon, in degrees

diff --git a/js/photons/model/PhotonMotionState.ts b/js/photons/model/PhotonMotionState.ts
@@ -19,9 +19,8 @@ export class PhotonMotionState {
   public constructor( public position: Vector2,
                       public direction: Vector2,
                       public probability: number ) {
-    // REVIEW: Is this actually a no-op? It does create a class instance right? I might not understand the full
-    // behavior of an empty constructor.
-    // no-op
+
+    // no additional initialization is required
   }
 
   /**