address code review comments, see #109

phetsims · Mar 7, 2025 · 4e8fd8b · 4e8fd8b
1 parent e1872ff
commit 4e8fd8b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/js/coins/view/CoinNode.ts b/js/coins/view/CoinNode.ts
@@ -38,14 +38,11 @@ export default class CoinNode extends Node {
 
   public constructor( radius: number,
                       crossFadeProperty: TReadOnlyProperty<number>,
-                      coinFaceParameters: CoinFaceParameters[],
+                      coinFaceParameters: [ CoinFaceParameters, CoinFaceParameters ],
                       providedOptions?: CoinNodeOptions ) {
 
     const options = optionize<CoinNodeOptions, SelfOptions, NodeOptions>()( {}, providedOptions );
 
-    // parameter checking
-    assert && assert( coinFaceParameters.length === 2, 'there should be exactly two sets of coin face parameters' );
-
     super( options );
 
     // Create the nodes that represent each of the two faces.

diff --git a/js/photons/view/PhotonSprites.ts b/js/photons/view/PhotonSprites.ts
@@ -38,8 +38,8 @@ class PhotonSprites extends Sprites {
   private readonly photonScale: number;
 
   // The sprites used to render the photons.
-  private readonly photonInteriorSprite: Sprite | null = null;
-  private readonly photonOutlineSprite: Sprite | null = null;
+  private readonly photonInteriorSprite: Sprite;
+  private readonly photonOutlineSprite: Sprite;
 
   public static readonly TARGET_PHOTON_VIEW_WIDTH = 10; // in screen coords, empirically determined to match the design