Skip to content

Commit

Permalink
update TODO issue links, #166 #138
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Mar 16, 2020
1 parent 390ed90 commit 6bc4832
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions js/grunt/PDOMComparison.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ module.exports = async ( repo, sha ) => {

const diff = htmlDiffer.diffHtml( workingCopyPDOM, oldShaPDOM );

// TODO https://github.com/phetsims/perennial/issues/166 better interpretation of the diff that is output. Perhaps by looking at "diff" more manually, see https://www.npmjs.com/package/html-differ
// TODO https://github.com/phetsims/perennial/issues/138 better interpretation of the diff that is output. Perhaps by looking at "diff" more manually, see https://www.npmjs.com/package/html-differ
console.log( logger.getDiffText( diff, { charsAroundDiff: 40 } ) );
};

Expand Down Expand Up @@ -139,8 +139,8 @@ const stashAll = async repos => {

/**
* Launch a chrome version, run the simulation, and get the PDOM from the simulation.
* TODO https://github.com/phetsims/perennial/issues/166 add in functions that can be executed to change the model in between tests.
* TODO https://github.com/phetsims/perennial/issues/166 maybe we could fuzz a few frames, and then test while setting the random seed to be the same for all pages
* TODO https://github.com/phetsims/perennial/issues/138 add in functions that can be executed to change the model in between tests.
* TODO https://github.com/phetsims/perennial/issues/138 maybe we could fuzz a few frames, and then test while setting the random seed to be the same for all pages
* @param repo
* @returns {Promise<string>}
*/
Expand All @@ -165,7 +165,7 @@ const launchSimAndGetPDOMText = async repo => {
const pdoms = await page.evaluate( () => {
return new Promise( function( resolve, reject ) {

// TODO https://github.com/phetsims/perennial/issues/166
// TODO https://github.com/phetsims/perennial/issues/138
// window.phet.sim.joist.frameEndedEmitter.addListener();

window.addEventListener( 'message', function( event ) {
Expand Down

0 comments on commit 6bc4832

Please sign in to comment.