Skip to content

Commit

Permalink
Check if disposed before handling end, see phetsims/make-a-ten#298
Browse files Browse the repository at this point in the history
  • Loading branch information
chrisklus committed Jul 14, 2021
1 parent 8b2dce6 commit bee6afb
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions js/common/view/PaperNumberNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,10 @@ class PaperNumberNode extends Node {
},

end: ( event, listener ) => {
tryToCombineNumbers( this.paperNumber );
paperNumber.endDragEmitter.emit( paperNumber );
if ( !this.isDisposed ) { // check if disposed before handling end, see https://github.com/phetsims/make-a-ten/issues/298
tryToCombineNumbers( this.paperNumber );
paperNumber.endDragEmitter.emit( paperNumber );
}
}
} );
this.moveDragHandler.isUserControlledProperty.link( controlled => {
Expand Down

0 comments on commit bee6afb

Please sign in to comment.