Skip to content

Commit

Permalink
Converting dot Utils usage, see phetsims/dot#4
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanolson committed Feb 14, 2025
1 parent f6633ae commit e682eb2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
13 changes: 7 additions & 6 deletions js/ChartTransform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,13 @@ import Emitter from '../../axon/js/Emitter.js';
import TEmitter from '../../axon/js/TEmitter.js';
import Range from '../../dot/js/Range.js';
import Transform1 from '../../dot/js/Transform1.js';
import Utils from '../../dot/js/Utils.js';
import Vector2 from '../../dot/js/Vector2.js';
import optionize from '../../phet-core/js/optionize.js';
import Orientation from '../../phet-core/js/Orientation.js';
import bamboo from './bamboo.js';
import ClippingType from './ClippingType.js';
import { linear } from '../../dot/js/util/linear.js';
import { roundSymmetric } from '../../dot/js/util/roundSymmetric.js';

type SelfOptions = {

Expand Down Expand Up @@ -125,8 +126,8 @@ class ChartTransform {

// For vertical, +y is usually up
const viewValue = axisOrientation === Orientation.HORIZONTAL ?
Utils.linear( transform.evaluate( modelRange.min ), transform.evaluate( modelRange.max ), lowSide, highSide, transformedValue ) :
Utils.linear( transform.evaluate( modelRange.max ), transform.evaluate( modelRange.min ), lowSide, highSide, transformedValue );
linear( transform.evaluate( modelRange.min ), transform.evaluate( modelRange.max ), lowSide, highSide, transformedValue ) :
linear( transform.evaluate( modelRange.max ), transform.evaluate( modelRange.min ), lowSide, highSide, transformedValue );
assert && assert( Number.isFinite( viewValue ), `viewValue should be finite: ${viewValue}` );
assert && assert( !isNaN( viewValue ), `viewValue should be a number: ${viewValue}` );

Expand Down Expand Up @@ -186,8 +187,8 @@ class ChartTransform {

// For vertical, +y is usually up
const out = axisOrientation === Orientation.HORIZONTAL ?
Utils.linear( lowSide, highSide, transform.evaluate( modelRange.min ), transform.evaluate( modelRange.max ), value ) :
Utils.linear( lowSide, highSide, transform.evaluate( modelRange.max ), transform.evaluate( modelRange.min ), value );
linear( lowSide, highSide, transform.evaluate( modelRange.min ), transform.evaluate( modelRange.max ), value ) :
linear( lowSide, highSide, transform.evaluate( modelRange.max ), transform.evaluate( modelRange.min ), value );
assert && assert( Number.isFinite( out ), 'out value should be finite' );
assert && assert( !isNaN( out ), 'out value should be a number' );

Expand Down Expand Up @@ -304,7 +305,7 @@ class ChartTransform {
function getValueForSpacing( value: number, clippingType: ClippingType,
origin: number, spacing: number, round: ( n: number ) => number ): number {
return clippingType === 'lenient' ?
Utils.roundSymmetric( ( value - origin ) / spacing ) :
roundSymmetric( ( value - origin ) / spacing ) :
round( ( value - origin ) / spacing );
}

Expand Down
4 changes: 2 additions & 2 deletions js/TickLabelSet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import Bounds2 from '../../dot/js/Bounds2.js';
import Range from '../../dot/js/Range.js';
import Utils from '../../dot/js/Utils.js';
import optionize from '../../phet-core/js/optionize.js';
import Orientation from '../../phet-core/js/Orientation.js';
import StrictOmit from '../../phet-core/js/types/StrictOmit.js';
Expand All @@ -19,6 +18,7 @@ import bamboo from './bamboo.js';
import ChartTransform from './ChartTransform.js';
import ClippingType from './ClippingType.js';
import TickMarkSet from './TickMarkSet.js';
import { toFixed } from '../../dot/js/util/toFixed.js';

type SelfOptions = {

Expand Down Expand Up @@ -74,7 +74,7 @@ class TickLabelSet extends Path {
skipCoordinates: [],
extent: TickMarkSet.DEFAULT_EXTENT,
clippingType: 'strict',
createLabel: ( value: number ) => new Text( Utils.toFixed( value, 1 ), { fontSize: 12 } ),
createLabel: ( value: number ) => new Text( toFixed( value, 1 ), { fontSize: 12 } ),
positionLabel: ( label: Node, tickBounds: Bounds2, axisOrientation: Orientation ) => {
if ( axisOrientation === Orientation.HORIZONTAL ) {

Expand Down

0 comments on commit e682eb2

Please sign in to comment.