Feature/terminology #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue with only the first few terms being recorded, and not being able to be deleted. It appears that the NodeMenu _updating flag is being erroneously set, or for some other reason the subsequent changes are being ignored.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Orion,
I've created this feature based on your old selectize branch. It adds a number of ways to use alternative terminology providers to do autocomplete on disorders, phenotypes and genes. I've written a bit of documentation on it in the terminology.md file.
I've not tested the CTSS terminology as I haven't ever setup a phenotips server for it to use.
I'm not sure the best way to deal with things like the bioportal api key or a fhir terminology server that needs authentication.
I do have some code thats part of my redcap plugin that uses redcap as a proxy and it hides the keys and does the authentication. But I didn't include it in this pull request as its tightly coupled to the redcap plugin and so is not relevant to others.
David Conlan