Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Can not Fetch preview information" message should be "You are not permitted to view this patient" #361

Open
pontikos opened this issue Jun 1, 2021 · 2 comments
Assignees

Comments

@pontikos
Copy link
Contributor

pontikos commented Jun 1, 2021

"Can not Fetch preview information" 404

shoudl be replace by "You are not permitted to view this patient" 403

this is for demo user

image

@alanwilter
Copy link
Collaborator

I can change that but we will need some change also in the JS side, in files like ...phenopolis_browser/frontend/src/redux/actions/gene.js, ...phenopolis_browser/frontend/src/serviceWorker.js etc.

@alanwilter
Copy link
Collaborator

The reasoning to use 404 instead of 403, if I remember well, was from Daniele, to avoid giving the idea to users that they may hack our app because the data is there in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants