Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refine API docs for files in Widgets dir #1920

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

devvaannsh
Copy link
Contributor

Add missing jsdoc for some const that were to be added in API docs

Copy link
Member

@abose abose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also create docs for entries in

  • StatusBar.js
  • Dialogs.js
  • DefaultDialogs.js

see tracking issue #1922

src/widgets/DropdownButton.js Outdated Show resolved Hide resolved
src/widgets/DropdownButton.js Outdated Show resolved Hide resolved
src/widgets/NotificationUI.js Show resolved Hide resolved
src/widgets/NotificationUI.js Show resolved Hide resolved
Copy link

@devvaannsh
Copy link
Contributor Author

devvaannsh commented Oct 29, 2024

StatusBar.js is already included in API docs. The jsdoc in the statusbar file is proper and requires no changes!

@abose abose merged commit 16e2eae into phcode-dev:main Oct 30, 2024
16 of 17 checks passed
@abose
Copy link
Member

abose commented Oct 30, 2024

LGTM Merging.
Thanks for contributing @devvaannsh

@devvaannsh devvaannsh deleted the widgets branch November 1, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants