feat: go to line will accept :ln:col format along with :ln,col (#2061)

phcode-dev · Jan 16, 2025 · ffe2fe2 · ffe2fe2
1 parent ad95682
commit ffe2fe2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/search/QuickOpen.js b/src/search/QuickOpen.js
@@ -89,7 +89,7 @@ define(function (require, exports, module) {
      * @private
      * @const {RegExp}
      */
-    var CURSOR_POS_EXP = new RegExp(":([^,]+)?(,(.+)?)?");
+    var CURSOR_POS_EXP = new RegExp(":([^,:]+)?([,:](.+)?)?");
 
     /**
      * Current plugin

diff --git a/test/spec/QuickOpen-integ-test.js b/test/spec/QuickOpen-integ-test.js
@@ -182,5 +182,21 @@ define(function (require, exports, module) {
         it("can directly open a file in a given line and column, centering that line on the screen", async function () {
             await quickOpenTest("lines:150,20", null, "lotsOfLines.html", 150, 20);
         });
+
+        it("can open a file and jump to a line and column with no space after comma", async function () {
+            await quickOpenTest("lines", ":50,20", "lotsOfLines.html", 50, 20);
+        });
+
+        it("can open a file and jump to a line and column with space after comma", async function () {
+            await quickOpenTest("lines", ":50, 20", "lotsOfLines.html", 50, 20);
+        });
+
+        it("can directly open a file with line:column format", async function () {
+            await quickOpenTest("lines:150:20", null, "lotsOfLines.html", 150, 20);
+        });
+
+        it("can directly open a file with line:column format and spaces", async function () {
+            await quickOpenTest("lines:150: 20", null, "lotsOfLines.html", 150, 20);
+        });
     });
 });