Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temperature error code despite success status code #174

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

lisabiermann
Copy link
Collaborator

This PR fixes #173.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (52326c8) to head (1bc597c).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/bounce_solution/bounce_solution.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
+ Coverage    82.83%   83.11%   +0.28%     
===========================================
  Files           54       54              
  Lines        19384    19383       -1     
  Branches      1852     1855       +3     
===========================================
+ Hits         16056    16111      +55     
+ Misses        3328     3272      -56     
Flag Coverage Δ
unittests 83.11% <75.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lisabiermann lisabiermann added the bug Something isn't working label Nov 6, 2024
@lisabiermann lisabiermann linked an issue Nov 6, 2024 that may be closed by this pull request
@vollous
Copy link
Collaborator

vollous commented Nov 29, 2024

Would you mind creating a unit test with Christoph's point so that this never happens again? In case we change the logic in the future.

Copy link
Collaborator

@vollous vollous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added some changes to the test to make it quicker (we were getting timeouts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants