-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix temperature error code despite success status code #174
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #174 +/- ##
===========================================
+ Coverage 82.83% 83.11% +0.28%
===========================================
Files 54 54
Lines 19384 19383 -1
Branches 1852 1855 +3
===========================================
+ Hits 16056 16111 +55
+ Misses 3328 3272 -56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Would you mind creating a unit test with Christoph's point so that this never happens again? In case we change the logic in the future. |
… into fix_Temp_from_VacFraction
…perature for point of issue #173"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I added some changes to the test to make it quicker (we were getting timeouts).
This PR fixes #173.