Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix true vacuum at high temperature #161

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

vollous
Copy link
Collaborator

@vollous vollous commented Jul 29, 2024

In some models, the BSMPT v2 global minimum does not find the global minimum, just non-global. We added a check to make sure that we always start from the true vacuum.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.84%. Comparing base (8f5d454) to head (a0a4c78).

Files with missing lines Patch % Lines
src/minimum_tracer/minimum_tracer.cpp 78.57% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #161      +/-   ##
===========================================
+ Coverage    82.81%   82.84%   +0.02%     
===========================================
  Files           54       54              
  Lines        19384    19394      +10     
  Branches      1852     1855       +3     
===========================================
+ Hits         16053    16066      +13     
+ Misses        3331     3328       -3     
Flag Coverage Δ
unittests 82.84% <78.57%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vollous vollous marked this pull request as ready for review July 30, 2024 12:53
@vollous vollous changed the base branch from master to develop November 5, 2024 21:39
@vollous vollous requested a review from phbasler November 29, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants