Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search feature #873

Open
wants to merge 11 commits into
base: Pharo13
Choose a base branch
from
Open

Conversation

hernanmd
Copy link
Member

This PR includes the first implementation of a live search in the New Settings Browser.

Details

  • It works by configuring a results tree, similar to the whole settings tree, based on the typed search input.
  • The minimum number of characters to start a search is currently 3, but could be easily made configurable.
  • It also auto-selects the first tab on setting category selection. Fixes StSettingsApplication should select the first pane when we select a topics pharo-project/pharo#17206
  • Setting node search was enhanced by querying each node label by substrings, then lowercase each one and comparing it against the lowercase input pattern.

@hernanmd hernanmd self-assigned this Oct 28, 2024
@hernanmd hernanmd added the enhancement New feature or request label Oct 28, 2024
@hernanmd
Copy link
Member Author

hernanmd commented Nov 6, 2024

There is a single failing test in the NewTools-Pharo integration but it seems unrelated ReflectivityControlTest>>#testLinkOneShot and I cannot reproduce it in the UI image:

Screenshot 2024-11-06 at 10 11 06

@hernanmd hernanmd requested a review from jecisc November 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StSettingsApplication should select the first pane when we select a topics
2 participants