Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates Scopes Editor #585

Merged
merged 86 commits into from
Dec 14, 2023
Merged

Conversation

carolahp
Copy link
Contributor

@carolahp carolahp commented Sep 19, 2023

Summary

This PR implements a presenter for creating and editing scopes.
Scopes are used to define parts of the code where refactorings will be applied.

How to test

Open the scope editor from the Pharo menu
image

While testing consider the following:

  • Calypso "Add to scope" commands in contextual menus are still not integrated to the scope editor, and will be replaced by new commands in the Pharo PR mentioned below

Pending features

  • Browse a scope on Calypso
  • Integrate with Pharo 12, displaying the new scopes in the presenters related to refactorings (I will create a PR on Pharo after this PR is merged)

@carolahp
Copy link
Contributor Author

carolahp commented Nov 6, 2023

hi @carolahp can you please rename the package NewTools-Scopes-Browser to NewTools-Scopes-Editor? the more time you take for doing it, more history we will lose in inceberg :(

hi @estebanlm , it's done, I didn't realize we were losing history

@carolahp carolahp marked this pull request as ready for review December 12, 2023 06:39
@Ducasse
Copy link
Contributor

Ducasse commented Dec 14, 2023

I will merge it so that we can try it.

@Ducasse Ducasse merged commit ba41315 into pharo-spec:Pharo12 Dec 14, 2023
2 checks passed
@estebanlm
Copy link
Member

why things cannot be tested by just load them, instead merging them into the trunk?

@Ducasse
Copy link
Contributor

Ducasse commented Dec 15, 2023

My point is not me just but all the people using the scope editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants