Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing a clipboard chest with a maximum size #35

Conversation

adri09070
Copy link
Collaborator

@adri09070 adri09070 commented Apr 24, 2024

This clipboard uses a linked list of names, so that I know which keys were added first and last.

This is also efficient in time to remove the first element of the list, which often happens when the clipboard is full (The key at first position is always the oldest key that was added and thus is always the key that is removed automatically when the clipboard is full).

I've arbitrarily set the default maximum size of a clipboard chest to 10 objects, but this can be changed

@adri09070 adri09070 added enhancement New feature or request documentation Improvements or additions to documentation labels Apr 30, 2024
@adri09070
Copy link
Collaborator Author

Unrelated failing tests @StevenCostiou

Copy link
Member

@StevenCostiou StevenCostiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of noisy changes due to automatic source rewriting (?)
The changes of the PR are good.
Ready to merge.

@StevenCostiou StevenCostiou merged commit 029ce79 into pharo-spec:master May 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants