Red test filter

.smalltalk.ston

@@ -8,7 +8,7 @@ SmalltalkCISpec {
     ],
     #testing : {
         #exclude : {
-            #classes : [ #MTAuxiliarTestClassForContinuingTestsExecutionAfterFirstFail ]
+            #classes : [ #MTAuxiliarTestClassForContinuingTestsExecutionAfterFirstFail, #MTAuxiliarTestClassForRedTestFilter ]
         }
     }
 }

src/MuTalk-CI/MTCoveragePropagationPreparation.class.st

@@ -175,7 +175,7 @@ MTCoveragePropagationPreparation >> runTestCase: testCaseReference [
 	| results |
 	counter := 1.
 	results := TestAsserter classForTestResult new.
-	results addAllResults: testCaseReference runUnchecked.
+	results addAllResults: testCaseReference run.
 	^ results
 ]
 

src/MuTalk-Model/MTAnalysis.class.st

@@ -57,7 +57,7 @@ MTAnalysis >> defaultBudget [
 	^ MTFreeBudget new
 ]
 
-{ #category : 'defaults' }
+{ #category : 'accessing - defaults' }
 MTAnalysis >> defaultLogger [
 
 	^ MTNullAnalysisLogger new
@@ -124,17 +124,15 @@ MTAnalysis >> generateMutations [
 { #category : 'running' }
 MTAnalysis >> generateResults [
 
-	| filteredTests |
 	mutantResults := OrderedCollection new.
-	filteredTests := testFilter filterTests: testCases.
 
 	mutations do: [ :aMutation |
 		(budget exceedsBudgetOn: mutantResults fromTotalMutations: mutations)
 			ifTrue: [ ^ mutantResults ].
 		logger logStartEvaluating: aMutation.
 		mutantResults add: ((MTMutantEvaluation
 				  for: aMutation
-				  using: filteredTests
+				  using: testCases
 				  following: testSelectionStrategy
 				  andConsidering: self coverageAnalysisResult)
 				 valueStoppingOnError: stopOnErrorOrFail) ].
@@ -143,10 +141,12 @@ MTAnalysis >> generateResults [
 
 { #category : 'running' }
 MTAnalysis >> initialTestRun [
-	"Do an initial run of the tests to check that they are all green.
-	Only green tests count for the mutation testing analysis"
+	"Runs all tests once and filters them"
 
-	testCases do: [ :aTestCase | aTestCase runChecked ]
+	| results |
+	results := testCases collect: [ :aTestCase | aTestCase run ].
+	testFilter validateFailuresIn: results.
+	testCases := testFilter filterTests: testCases
 ]
 
 { #category : 'initialization' }

src/MuTalk-Model/MTRedTestFilter.class.st

@@ -0,0 +1,21 @@
+Class {
+	#name : 'MTRedTestFilter',
+	#superclass : 'MTTestFilter',
+	#category : 'MuTalk-Model-Test filters',
+	#package : 'MuTalk-Model',
+	#tag : 'Test filters'
+}
+
+{ #category : 'enumerating' }
+MTRedTestFilter >> filterTests: aTestCaseCollection [
+
+	^ aTestCaseCollection reject: [ :testCase |
+		  self failuresOrErrorsIn: testCase lastResult ]
+]
+
+{ #category : 'testing' }
+MTRedTestFilter >> unwantedFailuresOrErrorsIn: results [
+	"It is not a problem if there are unwanted failures or errors because they will be filtered out anyway"
+
+	^ false
+]

src/MuTalk-Model/MTTestCaseReference.class.st

@@ -3,7 +3,8 @@ Class {
 	#superclass : 'Object',
 	#instVars : [
 		'testCase',
-		'lastTimeToRun'
+		'lastTimeToRun',
+		'lastResult'
 	],
 	#category : 'MuTalk-Model-Core',
 	#package : 'MuTalk-Model',
@@ -37,6 +38,18 @@ MTTestCaseReference >> initializeFor: aTestCase [
 	testCase := aTestCase
 ]
 
+{ #category : 'accessing' }
+MTTestCaseReference >> lastResult [
+
+	^ lastResult
+]
+
+{ #category : 'accessing' }
+MTTestCaseReference >> lastResult: anObject [
+
+	lastResult := anObject
+]
+
 { #category : 'accessing' }
 MTTestCaseReference >> lastTimeToRun [
 
@@ -63,10 +76,9 @@ MTTestCaseReference >> resources [
 
 { #category : 'evaluating' }
 MTTestCaseReference >> run [
-	"kept for retrocompatibility"
-
-	self deprecated: 'Use #runChecked instead.' transformWith: '`@receiver run' -> '`@receiver runChecked'.
-	^ self runChecked
+
+	lastTimeToRun := [ lastResult := self testCase run ] timeToRun.
+	^ lastResult
 ]
 
 { #category : 'evaluating' }
@@ -75,25 +87,6 @@ MTTestCaseReference >> run: aTestResult [
 	^ testCase run: aTestResult
 ]
 
-{ #category : 'evaluating' }
-MTTestCaseReference >> runChecked [
-
-	| result |
-	result := self runUnchecked.
-	(result unexpectedFailureCount > 0 or: [
-		 result unexpectedErrorCount > 0 ]) ifTrue: [
-		MTTestsWithErrorsException signal ].
-	^ result
-]
-
-{ #category : 'evaluating' }
-MTTestCaseReference >> runUnchecked [
-
-	| result |
-	lastTimeToRun := [ result := testCase run ] timeToRun.
-	^ result
-]
-
 { #category : 'accessing' }
 MTTestCaseReference >> selector [
 

src/MuTalk-Model/MTTestFilter.class.st

@@ -49,6 +49,12 @@ MTTestFilter >> excludedTestsFrom: aTestCaseCollection [
 	^ self subclassResponsibility
 ]
 
+{ #category : 'testing' }
+MTTestFilter >> failuresOrErrorsIn: result [
+
+	^ result failures isNotEmpty or: [ result unexpectedErrorCount > 0 ]
+]
+
 { #category : 'enumerating' }
 MTTestFilter >> filterTests: aTestCaseCollection [
 
@@ -80,3 +86,17 @@ MTTestFilter >> filteredTestsFrom: aTestCaseCollection [
 
 	^ self subclassResponsibility
 ]
+
+{ #category : 'testing' }
+MTTestFilter >> unwantedFailuresOrErrorsIn: results [
+	"Checks if the results contain failures or errors while they shouldn't"
+
+	^ results anySatisfy: [ :result | self failuresOrErrorsIn: result ]
+]
+
+{ #category : 'checking' }
+MTTestFilter >> validateFailuresIn: results [
+
+	(self unwantedFailuresOrErrorsIn: results) ifTrue: [
+		MTTestsWithErrorsException signal ]
+]

src/MuTalk-TestResources/MTAuxiliarTestClassForRedTestFilter.class.st

@@ -0,0 +1,18 @@
+Class {
+	#name : 'MTAuxiliarTestClassForRedTestFilter',
+	#superclass : 'TestCase',
+	#category : 'MuTalk-TestResources',
+	#package : 'MuTalk-TestResources'
+}
+
+{ #category : 'tests' }
+MTAuxiliarTestClassForRedTestFilter >> testWithError [
+
+	self error
+]
+
+{ #category : 'tests' }
+MTAuxiliarTestClassForRedTestFilter >> testWithoutError [
+
+	self assert: true
+]

src/MuTalk-Tests/MTRedTestFilterTest.class.st

@@ -0,0 +1,25 @@
+Class {
+	#name : 'MTRedTestFilterTest',
+	#superclass : 'MTTestFilterTest',
+	#category : 'MuTalk-Tests',
+	#package : 'MuTalk-Tests'
+}
+
+{ #category : 'running' }
+MTRedTestFilterTest >> runAnalysis [
+
+	self
+		runAnalysisWithFilter: (MTRedTestFilter new)
+		on: { MTAuxiliarClassForTestFilter }
+		withTests: { MTAuxiliarTestClassForRedTestFilter }
+]
+
+{ #category : 'tests' }
+MTRedTestFilterTest >> testRedTestIsExcluded [
+
+	self runAnalysis.
+
+	self assert: analysis testCases size equals: 1.
+	self assert: (analysis testCases includes: (MTTestCaseReference for:
+				  (MTAuxiliarTestClassForRedTestFilter selector: #testWithoutError)))
+]

src/MuTalk-Tests/MTTestCaseReferenceTest.class.st

@@ -14,7 +14,7 @@ MTTestCaseReferenceTest >> test1 [
 MTTestCaseReferenceTest >> testATestReferenceResult [
 	| testReference |
 	testReference := self testReferenceForTest1.
-	self assert: testReference runUnchecked errors isEmpty.
+	self assert: testReference run errors isEmpty.
 
 ]
 

src/MuTalk-Tests/MTTestCasesSelectionStrategyTest.class.st

@@ -20,6 +20,7 @@ MTTestCasesSelectionStrategyTest >> allTestsFromPackage [
 			   MTAuxiliarClassForTimeTestFilterTest.
 			   MTAuxiliarTestClassForBlockTestFilter.
 			   MTAuxiliarTestClassForPragmaTestFilter.
+			   MTAuxiliarTestClassForRedTestFilter.
 			   MTAuxiliarParametrizedTestClass })
 		  inject: OrderedCollection new
 		  into: [ :tests :testClass |

src/MuTalk-Tests/MTTimeTestFilterTest.class.st

@@ -49,6 +49,6 @@ MTTimeTestFilterTest >> testWith1SecondCondition [
 { #category : 'accessing' }
 MTTimeTestFilterTest >> timeToRunFor: aTestCaseReference [
 
-	aTestCaseReference runUnchecked.
+	aTestCaseReference run.
 	^ aTestCaseReference lastTimeToRun
 ]